Merge pull request #11529 from lat9nq/no-oob-names-pls

mii_types: Remove null terminator check
master
Narr the Reg 2023-09-17 14:27:44 +07:00 committed by GitHub
commit e18ff5cb4e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions

@ -606,15 +606,12 @@ struct Nickname {
static constexpr std::size_t MaxNameSize = 10;
std::array<char16_t, MaxNameSize> data;
// Checks for null, non-zero terminated or dirty strings
// Checks for null or dirty strings
bool IsValid() const {
if (data[0] == 0) {
return false;
}
if (data[MaxNameSize] != 0) {
return false;
}
std::size_t index = 1;
while (data[index] != 0) {
index++;