core: Make converting constructors explicit where applicable

Avoids unwanted implicit conversions. Thankfully, given the large amount
of cleanup in past PRs, only this tiny amount is left over to cover.
merge-requests/60/head
Lioncash 2018-07-23 23:10:48 +07:00
parent 47ac369180
commit 1d755abce4
5 changed files with 5 additions and 5 deletions

@ -35,7 +35,7 @@ static constexpr u128 DEFAULT_USER_ID{1ull, 0ull};
class IProfile final : public ServiceFramework<IProfile> { class IProfile final : public ServiceFramework<IProfile> {
public: public:
IProfile(u128 user_id) : ServiceFramework("IProfile"), user_id(user_id) { explicit IProfile(u128 user_id) : ServiceFramework("IProfile"), user_id(user_id) {
static const FunctionInfo functions[] = { static const FunctionInfo functions[] = {
{0, nullptr, "Get"}, {0, nullptr, "Get"},
{1, &IProfile::GetBase, "GetBase"}, {1, &IProfile::GetBase, "GetBase"},

@ -146,7 +146,7 @@ protected:
* @param max_sessions Maximum number of sessions that can be * @param max_sessions Maximum number of sessions that can be
* connected to this service at the same time. * connected to this service at the same time.
*/ */
ServiceFramework(const char* service_name, u32 max_sessions = DefaultMaxSessions) explicit ServiceFramework(const char* service_name, u32 max_sessions = DefaultMaxSessions)
: ServiceFrameworkBase(service_name, max_sessions, Invoker) {} : ServiceFrameworkBase(service_name, max_sessions, Invoker) {}
/// Registers handlers in the service. /// Registers handlers in the service.

@ -190,7 +190,7 @@ private:
u32 entryPoint; u32 entryPoint;
public: public:
ElfReader(void* ptr); explicit ElfReader(void* ptr);
u32 Read32(int off) const { u32 Read32(int off) const {
return base32[off >> 2]; return base32[off >> 2];

@ -79,7 +79,7 @@ enum class ResultStatus {
/// Interface for loading an application /// Interface for loading an application
class AppLoader : NonCopyable { class AppLoader : NonCopyable {
public: public:
AppLoader(FileSys::VirtualFile file) : file(std::move(file)) {} explicit AppLoader(FileSys::VirtualFile file) : file(std::move(file)) {}
virtual ~AppLoader() {} virtual ~AppLoader() {}
/** /**

@ -32,7 +32,7 @@ public:
* Recorder constructor * Recorder constructor
* @param initial_state Initial recorder state * @param initial_state Initial recorder state
*/ */
Recorder(const InitialState& initial_state); explicit Recorder(const InitialState& initial_state);
/// Finish recording of this Citrace and save it using the given filename. /// Finish recording of this Citrace and save it using the given filename.
void Finish(const std::string& filename); void Finish(const std::string& filename);