CCF_100
/
suyu-mirror
mirror of https://git.suyu.dev/suyu/suyu
1
0
Fork 0
Code Issues Releases Wiki Activity

svc: Resolve sign comparison warnings in WaitSynchronization() 

The loop's induction variable was signed, but we were comparing against
an unsigned variable.
merge-requests/60/head
Lioncash 2018-07-24 09:55:15 +07:00
parent 316c994f55
commit c73410bf2c
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/core/hle/kernel/svc.cpp
Unescape Escape View File

@ -165,11 +165,14 @@ static ResultCode WaitSynchronization(Handle* index, VAddr handles_address, u64
using ObjectPtr = SharedPtr<WaitObject>; using ObjectPtr = SharedPtr<WaitObject>;
std::vector<ObjectPtr> objects(handle_count); std::vector<ObjectPtr> objects(handle_count);
for (int i = 0; i < handle_count; ++i) { for (u64 i = 0; i < handle_count; ++i) {
Handle handle = Memory::Read32(handles_address + i * sizeof(Handle)); const Handle handle = Memory::Read32(handles_address + i * sizeof(Handle));
auto object = g_handle_table.Get<WaitObject>(handle); const auto object = g_handle_table.Get<WaitObject>(handle);
if (object == nullptr)
if (object == nullptr) {
return ERR_INVALID_HANDLE; return ERR_INVALID_HANDLE;
}
objects[i] = object; objects[i] = object;
} }