utils: cleaned up DumpTGA, removing redundancies

src/video_core/utils.cpp

@@ -8,6 +8,7 @@
 #include "video_core/utils.h"
 
 namespace VideoCore {
+
 /**
  * Dumps a texture to TGA
  * @param filename String filename to dump texture to
@@ -16,29 +17,20 @@ namespace VideoCore {
  * @param raw_data Raw RGBA8 texture data to dump
  * @todo This should be moved to some general purpose/common code
  */
-void DumpTGA(std::string filename, int width, int height, u8* raw_data) {
+void DumpTGA(std::string filename, short width, short height, u8* raw_data) {
-    TGAHeader hdr;
+    TGAHeader hdr = {0, 0, 2, 0, 0, 0, 0, width, height, 24, 0};
-    FILE* fout;
+    FILE* fout = fopen(filename.c_str(), "wb");
-    u8 r, g, b;
+    
-
-    memset(&hdr, 0, sizeof(hdr));
-    hdr.datatypecode = 2; // uncompressed RGB
-    hdr.bitsperpixel = 24; // 24 bpp
-    hdr.width = width;
-    hdr.height = height;
-
-    fout = fopen(filename.c_str(), "wb");
     fwrite(&hdr, sizeof(TGAHeader), 1, fout);
-    for (int i = 0; i < height; i++) {
+
-        for (int j = 0; j < width; j++) {
+    for (int y = 0; y < height; y++) {
-            b = raw_data[(3 * (i * width)) + (3 * j) + 0];
+        for (int x = 0; x < width; x++) {
-            g = raw_data[(3 * (i * width)) + (3 * j) + 1];
+            putc(raw_data[(3 * (y * width)) + (3 * x) + 0], fout); // b
-            r = raw_data[(3 * (i * width)) + (3 * j) + 2];
+            putc(raw_data[(3 * (y * width)) + (3 * x) + 1], fout); // g
-            putc(b, fout);
+            putc(raw_data[(3 * (y * width)) + (3 * x) + 2], fout); // r
-            putc(g, fout);
-            putc(r, fout);
         }
     }
+    
     fclose(fout);
 }
 } // namespace

src/video_core/utils.h

@@ -59,6 +59,6 @@ struct TGAHeader {
  * @param raw_data Raw RGBA8 texture data to dump
  * @todo This should be moved to some general purpose/common code
  */
-void DumpTGA(std::string filename, int width, int height, u8* raw_data);
+void DumpTGA(std::string filename, short width, short height, u8* raw_data);
 
 } // namespace