CCF_100
/
yuzu-mirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tas_input: Avoid minor copies in Read/WriteCommandButtons() 

We don't need to copy the whole pair
master
Lioncash 2021-12-13 11:36:48 +07:00
parent 734fb180bb
commit 54ca48e8b7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/input_common/drivers/tas_input.cpp
Unescape Escape View File

@ -244,7 +244,7 @@ u64 Tas::ReadCommandButtons(const std::string& line) const {
std::string button_line;
u64 buttons = 0;
while (std::getline(button_text, button_line, ';')) {
for (auto [text, tas_button] : text_to_tas_button) {
for (const auto& [text, tas_button] : text_to_tas_button) {
if (text == button_line) {
buttons |= static_cast<u64>(tas_button);
break;
@ -256,7 +256,7 @@ u64 Tas::ReadCommandButtons(const std::string& line) const {
std::string Tas::WriteCommandButtons(u64 buttons) const {
std::string returns;
for (auto [text_button, tas_button] : text_to_tas_button) {
for (const auto& [text_button, tas_button] : text_to_tas_button) {
if ((buttons & static_cast<u64>(tas_button)) != 0) {
returns += fmt::format("{};", text_button);
}