CCF_100
/
yuzu-mirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add missing return values in ForeachDirectoryEntry 

ForeachDirectoryEntry is changed by #1256 ,but return value at last line
was missing.
master
LFsWang 2015-12-23 16:26:38 +07:00
parent ed20141346
commit 8376821776
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/common/file_util.cpp
Unescape Escape View File

@ -427,6 +427,9 @@ bool ForeachDirectoryEntry(unsigned* num_entries_out, const std::string &directo
// How many files + directories we found // How many files + directories we found
unsigned found_entries = 0; unsigned found_entries = 0;
// Save the status of callback function
bool callback_error = false;
#ifdef _WIN32 #ifdef _WIN32
// Find the first file in the directory. // Find the first file in the directory.
WIN32_FIND_DATA ffd; WIN32_FIND_DATA ffd;
@ -455,8 +458,10 @@ bool ForeachDirectoryEntry(unsigned* num_entries_out, const std::string &directo
continue; continue;
unsigned ret_entries; unsigned ret_entries;
if (!callback(&ret_entries, directory, virtual_name)) if (!callback(&ret_entries, directory, virtual_name)) {
callback_error = true;
break; break;
}
found_entries += ret_entries; found_entries += ret_entries;
#ifdef _WIN32 #ifdef _WIN32
@ -467,9 +472,14 @@ bool ForeachDirectoryEntry(unsigned* num_entries_out, const std::string &directo
closedir(dirp); closedir(dirp);
#endif #endif
// num_entries_out is allowed to be specified nullptr, in which case we shouldn't try to set it if (!callback_error) {
if (num_entries_out != nullptr) // num_entries_out is allowed to be specified nullptr, in which case we shouldn't try to set it
*num_entries_out = found_entries; if (num_entries_out != nullptr)
*num_entries_out = found_entries;
return true;
} else {
return false;
}
} }
unsigned ScanDirectoryTree(const std::string &directory, FSTEntry& parent_entry) unsigned ScanDirectoryTree(const std::string &directory, FSTEntry& parent_entry)