CCF_100
/
yuzu-mirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

time_zone_content_manager: Fix out of bounds read 

There were cases where raw_data didn't contain enough
space to hold the zero terminator.

This was caught with -fsanitize=address.
master
ReinUsesLisp 2020-03-18 19:05:23 +07:00
parent 56ea0f8acb
commit ac7ee21331
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/hle/service/time/time_zone_content_manager.cpp
Unescape Escape View File

@ -53,7 +53,7 @@ static std::vector<std::string> BuildLocationNameCache(Core::System& system) {
return {}; return {};
} }
std::vector<char> raw_data(binary_list->GetSize()); std::vector<char> raw_data(binary_list->GetSize() + 1);
binary_list->ReadBytes<char>(raw_data.data(), binary_list->GetSize()); binary_list->ReadBytes<char>(raw_data.data(), binary_list->GetSize());
std::stringstream data_stream{raw_data.data()}; std::stringstream data_stream{raw_data.data()};