CCF_100
/
yuzu-mirror
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

applets/swkbd: Make use of std::move where applicable 

Avoids redundant string copies
master
Morph 2021-05-27 23:22:38 +07:00
parent 247cd92216
commit c68255f70f
2 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/core/hle/service/am/applets/software_keyboard.cpp
Unescape Escape View File

@ -290,10 +290,10 @@ void SoftwareKeyboard::ProcessTextCheck() {
SubmitNormalOutputAndExit(SwkbdResult::Ok, current_text); SubmitNormalOutputAndExit(SwkbdResult::Ok, current_text);
break; break;
case SwkbdTextCheckResult::Failure: case SwkbdTextCheckResult::Failure:
ShowTextCheckDialog(SwkbdTextCheckResult::Failure, text_check_message); ShowTextCheckDialog(SwkbdTextCheckResult::Failure, std::move(text_check_message));
break; break;
case SwkbdTextCheckResult::Confirm: case SwkbdTextCheckResult::Confirm:
ShowTextCheckDialog(SwkbdTextCheckResult::Confirm, text_check_message); ShowTextCheckDialog(SwkbdTextCheckResult::Confirm, std::move(text_check_message));
break; break;
case SwkbdTextCheckResult::Silent: case SwkbdTextCheckResult::Silent:
default: default:
@ -487,7 +487,7 @@ void SoftwareKeyboard::InitializeFrontendKeyboard() {
max_text_length <= 32 ? SwkbdTextDrawType::Line : SwkbdTextDrawType::Box; max_text_length <= 32 ? SwkbdTextDrawType::Line : SwkbdTextDrawType::Box;
Core::Frontend::KeyboardInitializeParameters initialize_parameters{ Core::Frontend::KeyboardInitializeParameters initialize_parameters{
.ok_text{ok_text}, .ok_text{std::move(ok_text)},
.header_text{}, .header_text{},
.sub_text{}, .sub_text{},
.guide_text{}, .guide_text{},
@ -563,10 +563,10 @@ void SoftwareKeyboard::InitializeFrontendKeyboard() {
: false; : false;
Core::Frontend::KeyboardInitializeParameters initialize_parameters{ Core::Frontend::KeyboardInitializeParameters initialize_parameters{
.ok_text{ok_text}, .ok_text{std::move(ok_text)},
.header_text{header_text}, .header_text{std::move(header_text)},
.sub_text{sub_text}, .sub_text{std::move(sub_text)},
.guide_text{guide_text}, .guide_text{std::move(guide_text)},
.initial_text{initial_text}, .initial_text{initial_text},
.max_text_length{max_text_length}, .max_text_length{max_text_length},
.min_text_length{min_text_length}, .min_text_length{min_text_length},
@ -595,7 +595,7 @@ void SoftwareKeyboard::ShowNormalKeyboard() {
void SoftwareKeyboard::ShowTextCheckDialog(SwkbdTextCheckResult text_check_result, void SoftwareKeyboard::ShowTextCheckDialog(SwkbdTextCheckResult text_check_result,
std::u16string text_check_message) { std::u16string text_check_message) {
frontend.ShowTextCheckDialog(text_check_result, text_check_message); frontend.ShowTextCheckDialog(text_check_result, std::move(text_check_message));
} }
void SoftwareKeyboard::ShowInlineKeyboard() { void SoftwareKeyboard::ShowInlineKeyboard() {

25
src/yuzu/applets/software_keyboard.cpp
Unescape Escape View File

@ -1101,12 +1101,11 @@ void QtSoftwareKeyboardDialog::NormalKeyboardButtonClicked(QPushButton* button)
} }
if (button == ui->button_ok || button == ui->button_ok_shift || button == ui->button_ok_num) { if (button == ui->button_ok || button == ui->button_ok_shift || button == ui->button_ok_num) {
if (ui->topOSK->currentIndex() == 1) { auto text = ui->topOSK->currentIndex() == 1
emit SubmitNormalText(SwkbdResult::Ok, ? ui->text_edit_osk->toPlainText().toStdU16String()
ui->text_edit_osk->toPlainText().toStdU16String()); : ui->line_edit_osk->text().toStdU16String();
} else {
emit SubmitNormalText(SwkbdResult::Ok, ui->line_edit_osk->text().toStdU16String()); emit SubmitNormalText(SwkbdResult::Ok, std::move(text));
}
return; return;
} }
@ -1265,13 +1264,11 @@ void QtSoftwareKeyboardDialog::TranslateButtonPress(HIDButton button) {
if (is_inline) { if (is_inline) {
emit SubmitInlineText(SwkbdReplyType::DecidedCancel, current_text, cursor_position); emit SubmitInlineText(SwkbdReplyType::DecidedCancel, current_text, cursor_position);
} else { } else {
if (ui->topOSK->currentIndex() == 1) { auto text = ui->topOSK->currentIndex() == 1
emit SubmitNormalText(SwkbdResult::Cancel, ? ui->text_edit_osk->toPlainText().toStdU16String()
ui->text_edit_osk->toPlainText().toStdU16String()); : ui->line_edit_osk->text().toStdU16String();
} else {
emit SubmitNormalText(SwkbdResult::Cancel, emit SubmitNormalText(SwkbdResult::Cancel, std::move(text));
ui->line_edit_osk->text().toStdU16String());
}
} }
break; break;
case HIDButton::Y: case HIDButton::Y:
@ -1563,7 +1560,7 @@ void QtSoftwareKeyboard::ShowNormalKeyboard() const {
void QtSoftwareKeyboard::ShowTextCheckDialog( void QtSoftwareKeyboard::ShowTextCheckDialog(
Service::AM::Applets::SwkbdTextCheckResult text_check_result, Service::AM::Applets::SwkbdTextCheckResult text_check_result,
std::u16string text_check_message) const { std::u16string text_check_message) const {
emit MainWindowShowTextCheckDialog(text_check_result, text_check_message); emit MainWindowShowTextCheckDialog(text_check_result, std::move(text_check_message));
} }
void QtSoftwareKeyboard::ShowInlineKeyboard( void QtSoftwareKeyboard::ShowInlineKeyboard(